Fix 404 error page formatting and broken links - #4139
Conversation
szakarias
left a comment
There was a problem hiding this comment.
Thanks for the PR.
I think for the example URL this still leaves many broken links on the page. Mabye a better short-term fix would be to only have one link to the front page of the latest version....
The more comprehensive fix would be to resolve all relative paths even when the base URL is broken.
In the future I think someone can implement this problem, but I'll see if I can do it for everyone |
|
@Franklyn-R-Silva , are you planning to work on this anytime soon? |
This PR addresses the issues reported in dart-lang/sdk#62262 regarding the confusing 404 error page.
Changes:
{{>search_sidebar}}tag, as search scripts typically fail to load on 404 pages, leaving these boxes stuck in a "Loading..." state.Testing:
dart bin/dartdoc.dartand verified the resulting404error.html. The inert elements are gone and the layout is much cleaner.Fixes dart-lang/sdk#62262