Skip to content

Support use-flutter option in groundskeeper workflow - #444

Draft
mosuem wants to merge 3 commits into
mainfrom
groundskeeper-flutter-dev
Draft

Support use-flutter option in groundskeeper workflow#444
mosuem wants to merge 3 commits into
mainfrom
groundskeeper-flutter-dev

Conversation

@mosuem

@mosuem mosuem commented Aug 18, 2026

Copy link
Copy Markdown
Member

Adds a use-flutter option (defaulting to false) to groundskeeper.yml.

When use-flutter is true:

  • Uses subosito/flutter-action with the specified channel (sdk, defaulting to dev) so that Flutter and Dart are available on PATH for Flutter packages (such as cronet_http or ok_http).

When use-flutter is false (default):

  • Uses dart-lang/setup-dart with the specified SDK version / channel (defaulting to dev), keeping setup fast and lightweight for pure Dart packages.

Addresses feedback from dart-lang/http#1959.

@github-actions github-actions Bot added package:firehose type-infra A repository infrastructure change or enhancement labels Aug 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CHANGELOG.md for the firehose package to document the use of the Flutter dev channel in the groundskeeper workflow to support Flutter packages. There are no review comments, so I have no feedback to provide.

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

PR Health

Unused Dependencies ✔️
Package Status
firehose ✔️ All dependencies utilized correctly.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
firehose Non-Breaking 0.13.0 0.13.2-wip 0.13.2-wip ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

@mosuem mosuem changed the title Use Flutter dev channel in groundskeeper workflow Support use-flutter option in groundskeeper workflow Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:firehose type-infra A repository infrastructure change or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant