Repository navigation
Conversation
Every event now carries the bundled DasherCore's version (git describe of the third_party/DasherCore pin, e.g. 'v0.2.24-4-gc7899b65' — exact pin commits matter for triage). Engine drift becomes visible in the PostHog version-adoption tile instead of being discovered by survey. Build-time derivation is exact here because the engine is bundled into the APK (the pin IS what runs); the runtime dasher_get_engine_version() call (DasherCore#109) can replace it at the next engine bump. Signed-off-by: will wade <willwade@gmail.com>
…behind (RFC 0022 item 2) Weekly + on-demand: compares the submodule pin to the newest DasherCore v* tag and, when behind, opens a PR bumping the pin with the engine changelog in the body. Green CI = merge; adaptation work rides the PR. Same-repo GITHUB_TOKEN only — no org app, no PAT. The only per-repo line is SUBMODULE (third_party/DasherCore here). Signed-off-by: will wade <willwade@gmail.com>
Configuration fails if the pinned DasherCore's DASHER_CAPI_VERSION (dash.h) is below the declared requirement. 'Can I bump the engine?' becomes a build check; the engine-bump PR's green CI now proves API compatibility too. Signed-off-by: will wade <willwade@gmail.com>
…C 0022 item 6) The canonical analytics-events.json moves to governance (union of all frontends' events); this repo's copy becomes generated. Weekly + on demand: pull canonical, PR the diff. Signed-off-by: will wade <willwade@gmail.com>
…dules) CI's submodule checkout carries no tags; git describe's merged stderr became the BuildConfig value — multi-line garbage that broke the generated Java string literal. Only a real describe shape is accepted now; anything else degrades to 'unknown'. Signed-off-by: will wade <willwade@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Governance#57 item 6: the canonical analytics schema now lives in governance (analytics/analytics-events.json — union, incl. GTK's engine_error/reset events). This workflow keeps the repo copy generated: weekly + dispatch, pulls canonical, PRs the diff. The governance PR includes the canonical file itself.