Skip to content

Fix curator's name in criTRia JSON file - #519

Merged
hdashnow merged 4 commits into
mainfrom
critria-typo
Oct 7, 2026
Merged

hdashnow merged 4 commits into
mainfrom
critria-typo

Conversation

@hdashnow

@hdashnow hdashnow commented Sep 17, 2026 •

Copy link
Copy Markdown
Member

Description

Split the criTRia Curator field into a single primary Curator and a new Contributors field, so each curation credits one lead curator and lists everyone else who contributed to or reviewed it.

Curators were set from the criTRia separate-scoring sheet (Person column). A curator listed only by first name was expanded to their full name, and "Macayla, Laurel" was taken as Macayla. The exceptions:

  • ClinGen curations (12 loci) keep the GCEP as curator (e.g. "Epilepsy GCEP") and have no contributors.
  • Re-curated loci: the primary curator is the person who substantially re-curated the locus (changed the cited papers or the score), going by commit history on the PR branches:
    • Harriet Dashnow: ALS1_NIPA1, FXS_FMR1, DRPLA_ATN1, HPE5_ZIC2, OPDM5_ABCD3
    • Gabriel Zinser: FRA12A_DIP2B
  • Not in the scoring sheet: EPM_CSNK1E and FXTAS,POF1_FMR1 use the first-listed curator (Macayla Weiner).

Harriet Dashnow was also added as a contributor on 12 loci where her review commits changed the evidence or the cited papers but she wasn't listed: SCA12_PPP2R2B, SCA17_TBP, NIID_NOTCH2NLC, SCA10_ATXN10, SCA31_BEAN1, EPM_CSNK1E, EIEE1_ARX, CJD_PRNP, SD5_HOXD13, HFG_HOXA13-III, SCA36_NOP56, SCA6_CACNA1A.

Major Changes

  • New data field: Contributors (comma-separated string, or null) in criTRia-curations.schema.json.
  • Curator now holds a single name (a person or a ClinGen GCEP).
  • Schema guidance: if a curation is completely rewritten by a new curator, the original curator moves to Contributors and the date is updated.

Minor Changes

  • criTRia locus pages: the "Curator(s)" box is renamed "Curator", and a "Contributors" box is shown when the field is set.
  • Removed a trailing space from one "Amyotrophic Lateral Sclerosis Spectrum Disorders GCEP" entry.
  • Typo: Laural -> Laurel

Checklist

  • All changes are well summarized
  • Check all tests pass
  • Check that the website preview looks good
  • Update the STRchive version in CITATION.cff, format X.Y.Z. If any major changes, increment Y. If only minor changes, increment Z. If the breaking change (rare), increment X.
  • Ask someone to review this PR

@netlify

netlify Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for strchive ready!

Name Link
🔨 Latest commit 48000bd
🔍 Latest deploy log https://app.netlify.com/projects/strchive/deploys/6ac01153fa35d2000893670d
😎 Deploy Preview https://deploy-preview-519--strchive.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hdashnow
hdashnow requested review from elbayaliyev and a balanced review from Copilot and removed request for Copilot October 2, 2026 20:11
@hdashnow hdashnow changed the title Fix typo in curator's name in JSON file Fix curator's name in criTRia JSON file Oct 2, 2026
Co-authored-by: hdashnow <3794821+hdashnow@users.noreply.github.com>
@hdashnow
hdashnow merged commit 758aa47 into main Oct 7, 2026
6 checks passed
@hdashnow
hdashnow deleted the critria-typo branch October 7, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants