sdk%feat(num): decouple NumCodec from codec feat, rename to Numeric, fix byte reversal display bug, restore trait use in open enums, drop Hash512

docs/samples/solver/solver.rs

@@ -15,7 +15,7 @@ use bitcoin_primitives::script::{ScriptPubKeyBuf, ScriptSigBuf};
 use bitcoin_units::Amount;
 use dash_num::{Arith256, CompactTarget, Hash256};
 use dash_primitives::{BlockHash, BlockHeader, MerkleRoot, OutPoint, Transaction, TxHash, TxIn, TxOut, TxType};
-use dash_types::codec::Hashable;
+use dash_types::{Hashable, Numeric};
 use hex_conservative::FromHex;
 use serde::{Deserialize, Serialize};
 use wasm_bindgen::prelude::*;
@@ -66,7 +66,7 @@ pub fn merkle_root(script_sig_hex: &str, script_pubkey_hex: &str, amount_duffs:
   let sig_bytes = Vec::<u8>::from_hex(script_sig_hex).map_err(|e| format!("invalid scriptSig hex: {e}"))?;
   let pk_bytes = Vec::<u8>::from_hex(script_pubkey_hex).map_err(|e| format!("invalid scriptPubKey hex: {e}"))?;
   let coinbase = build_coinbase(sig_bytes, pk_bytes, amount_duffs)?;
-  let root = MerkleRoot::from_bytes(*coinbase.hash().as_bytes());
+  let root = MerkleRoot::from_lendian(*coinbase.hash().as_bytes());
   Ok(format!("{root}"))
 }
 
@@ -89,7 +89,7 @@ pub fn scanhash(
   let pk_bytes = Vec::<u8>::from_hex(script_pubkey_hex).map_err(|e| format!("invalid scriptPubKey hex: {e}"))?;
 
   let coinbase = build_coinbase(sig_bytes, pk_bytes, amount_duffs)?;
-  let merkle_root = MerkleRoot::from_bytes(*coinbase.hash().as_bytes());
+  let merkle_root = MerkleRoot::from_lendian(*coinbase.hash().as_bytes());
 
   let header = BlockHeader {
     version,
@@ -101,7 +101,7 @@ pub fn scanhash(
   };
   let mut header_buf = encode_to_vec(&header);
 
-  let decoded = CompactTarget(bits).decode();
+  let decoded = CompactTarget::new(bits).expand();
   if decoded.negative || decoded.overflow {
     return Err("invalid compact target".to_string());
   }

maint/codeql/rust/lib/imports.qll

@@ -67,16 +67,32 @@ predicate isMacroReexport(Use u) {
 
 /** Holds if `u` is an allowlisted re-export from a foreign crate. */
 private predicate isAllowlistedReexport(Use u) {
-  usePrefix(u) = "dash_types_marker" and
-  fileOf(u).getAbsolutePath().matches("%pkgs/types/%")
+  fileOf(u).getAbsolutePath().matches("%pkgs/num/%") and
+  (
+    // Crate emits types relying on traits defined by a dependency, part of public API
+    usePrefix(u) = "dash_types" and
+    u.getUseTree().getPath().getSegment().getIdentifier().getText() = "Numeric"
+  )
   or
-  usePrefix(u) = "dash_pkc" and
-  u.getUseTree().getPath().getSegment().getIdentifier().getText() = "__PubKeyHash" and
-  fileOf(u).getAbsolutePath().matches("%pkgs/script/%")
+  fileOf(u).getAbsolutePath().matches("%pkgs/script/%") and
+  (
+    // Workaround for the orphan rule, not part of public API
+    usePrefix(u) = "dash_pkc" and
+    u.getUseTree().getPath().getSegment().getIdentifier().getText() = "__PubKeyHash"
+    or
+    // Workaround for the orphan rule, not part of public API
+    usePrefix(u) = "dash_types" and
+    u.getUseTree().getPath().getSegment().getIdentifier().getText() = "__ScriptHash"
+  )
   or
-  usePrefix(u) = "dash_types" and
-  u.getUseTree().getPath().getSegment().getIdentifier().getText() = "__ScriptHash" and
-  fileOf(u).getAbsolutePath().matches("%pkgs/script/%")
+  fileOf(u).getAbsolutePath().matches("%pkgs/types/%") and
+  (
+    // Sub-crate isolation demands re-exports, part of public API
+    usePrefix(u) = "dash_types_marker"
+    or
+    // Crate emits types relying on types or traits defined by a dependency, part of public API
+    usePrefix(u) = "zeroize"
+  )
 }
 
 /**

maint/codeql/rust/lib/policy.qll

@@ -295,7 +295,7 @@ predicate isUnencodableCrate(File f) {
 /** Declaration slots that define the required source ordering. */
 newtype TDeclSlot =
   TDefinition() or
-  TNumCodecImpl() or
+  TNumericImpl() or
   TBaseCodecImpl() or
   TCheckableImpl() or
   THashableImpl() or
@@ -308,7 +308,7 @@ class DeclSlot extends TDeclSlot {
   int getOrder() {
     this = TDefinition() and result = 0
     or
-    this = TNumCodecImpl() and result = 1
+    this = TNumericImpl() and result = 1
     or
     this = TBaseCodecImpl() and result = 2
     or
@@ -325,7 +325,7 @@ class DeclSlot extends TDeclSlot {
   string toString() {
     this = TDefinition() and result = "definition"
     or
-    this = TNumCodecImpl() and result = "NumCodec impl"
+    this = TNumericImpl() and result = "Numeric impl"
     or
     this = TBaseCodecImpl() and
     result = "BaseCodec/Encode/Decode impl"
@@ -342,7 +342,7 @@ class DeclSlot extends TDeclSlot {
 
 /** Maps a trait name to its declaration slot. */
 DeclSlot traitSlot(string traitName) {
-  traitName = "NumCodec" and result = TNumCodecImpl()
+  traitName = "Numeric" and result = TNumericImpl()
   or
   traitName = "BaseCodec" and result = TBaseCodecImpl()
   or

maint/semgrep/rust/types.yml

@@ -9,7 +9,7 @@ rules:
         - /pkgs/types/src/entity.rs
         - /pkgs/types/src/macros.rs
         - /pkgs/types/src/secret.rs
-        - /pkgs/types/src/uint.rs
+        - /pkgs/types/src/numeric.rs
     pattern-regex: '\b(?:make|impl)_(?:bytes|num|type)!\s*[({]'
 
   - id: types-macro-generics-bracketed

maint/semgrep/rust/workspace.yml

@@ -237,3 +237,19 @@ rules:
       include: [/pkgs/**/*.rs, /docs/samples/**/*.rs]
       exclude: ["**/lib.rs", "**/mod.rs"]
     pattern-regex: '^\s*pub\s+use\s'
+
+  - id: bytes-rev-means-hash
+    message: "dash_types::make_bytes! is not suitable for hash types, use dash_num::make_hash! instead"
+    severity: ERROR
+    languages: [rust]
+    paths:
+      include: [/pkgs/**/*.rs, /docs/samples/**/*.rs]
+      exclude:
+        - /pkgs/types/src/entity.rs # declares the generator
+        - /pkgs/types/src/secret.rs # declares its secret sibling
+    pattern-regex: |-
+      (?x)
+      \b (?: make | derive ) _ s? bytes !  # a byte-bag generator invocation
+      \s* [({]                             # ... opening its arguments
+      (?: [^\n]* \n ){0,6}?                # ... over its doc comment, if any
+      [^\n]* \b rev \b                     # ... to the order token's line

pkgs/num/Cargo.toml

@@ -11,14 +11,19 @@ rust-version.workspace = true
 
 [features]
 default = []
-std = ["bitcoin-consensus-encoding?/std", "dash-types/std"]
+std = [
+  "bitcoin-consensus-encoding?/std",
+  "dash-types/std",
+  "hex-conservative/std",
+]
 full = ["std", "codec", "serde"]
 codec = ["dep:bitcoin-consensus-encoding", "dash-types/codec"]
 serde = ["dep:serde", "dash-types/serde"]
 
 [dependencies]
 bitcoin-consensus-encoding = { workspace = true, optional = true }
 dash-types = { version = "0.0.0", path = "../types", default-features = false }
+hex-conservative = { version = "0.3", default-features = false }
 serde = { version = "1", default-features = false, features = [
   "derive",
   "alloc",