Repository navigation
Connect from a data.all front page URL (client(dataall_url=...)), 0.6.0 - #55
Merged
TejasRGitHub merged 2 commits intoSep 25, 2026
Merged
Conversation
- dataall_core.discovery: read auth type, identity provider, client id, redirect URI and API endpoint from the deployed frontend bundle and build a Profile from them (moved here from the CLI so the SDK can use it) - DataallClient.client(dataall_url=...): discover and save the profile, named after the page host, when it is not configured yet - Version 0.6.0 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Deep links such as /console/environments resolve to the same index.html. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Lets the SDK connect with nothing but the data.all front page URL:
dataall_core.discovery: fetches the front page, finds thestatic/js/main.*.jsbundle and reads theREACT_APP_*values the frontend build inlines.REACT_APP_CUSTOM_AUTH*means an OIDC deployment (OidcBrowserAuth, loopback redirect defaults,openid offline_access);REACT_APP_COGNITO_*means Cognito (client id, hosted UI domain, sign-in redirect).profile_from_frontend()turns that into aProfileand raisesMissingParametersExceptionnaming anything that could not be read. This is the discovery the CLI added in configure: add OidcBrowserAuth and --dataall_url front-page discovery dataall-cli#53, moved here so both packages share it; the CLI will import it from core.DataallClient.client()gainsdataall_url. If the profile exists inconfig.yamlit is used as is (with a warning when it points at a different front page). Otherwise the profile is discovered and saved under the page's host name, or underprofile=when given, so later calls skip the lookup and tokens persist between runs. The first API call then triggers the normalOidcBrowserAuthlogin.DEFAULT_FALLBACK_REDIRECT_URIadded next to the otherOidcBrowserAuthdefaults.profile_from_frontenddefaults;client(dataall_url=...)discovers and saves, reuses an existing profile without a lookup, honoursprofile=, and surfaces missing values. Existing tests unchanged.Relates
client(dataall_url=...)Security
httpxGETs against the URL the caller supplies (front page, then the bundle it references); values are extracted with anchored regular expressions on known variable names and only populate profile fields the user could type by hand. Nothing is executed or deserialized beyondresponse.text. Noeval.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
🤖 Generated with Claude Code