Repository navigation
ci: clarify Go replay backend reporting - #524
Merged
Merged
Conversation
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
vuanhphung
marked this pull request as ready for review
October 30, 2026 19:21
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: 1 Nit
Looks good. This PR only updates comments, log messages and the PR comment text, and the backends ternary is correct for each label → mode mapping. One nit: the payload still sends go_mode: 'thrift' on replay while the logs report thrift+sea.
Other findings
- ⚪ Nit — Replay dispatches still send
go_mode: 'thrift'(merge-queue L262 and the*branch in the label step), while the logs and PR comment now saythrift+sea. That's only accurate as long as driver-test ignoresgo_modein replay mode. Consider sending a neutral value such asgo_mode: 'all', or adding a comment thatgo_modeis ignored for replay, so the payload and the reported backends don't contradict each other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replay dispatches now run both Thrift and SEA in driver-test, but the Go workflow still describes Thrift-only coverage. Update its comments, dispatch logs, and PR notification to report both replay backends; live previews report the selected backend.
Validated with actionlint, YAML and JavaScript syntax checks, and git diff --check.