Repository navigation
test: drop --warn-error from view lifecycle tests - #1756
Merged
Merged
Conversation
The --warn-error runs failed on warnings unrelated to the view lifecycle: dbt-core before 1.12.2 reports view_update_via_alter as an unrecognized config key, and some auth paths emit warnings. The server-state assertions stay. Also move the 1.13.0 release date to Oct 29, 2026. Co-authored-by: Isaac <no-reply@databricks.com>
2 of 3 tasks
Coverage report
This PR does not seem to contain any modification to coverable code. |
sd-db
enabled auto-merge (squash)
October 28, 2026 14:15
jprakash-db
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TestViewLifecycleIgnoresMaterializationFlagandTestViewLifecycleMaterializationFlagOnrandbt --warn-error run, so any warning failed them, including warnings unrelated to the view lifecycle. On the lowest-direct dependency floor, dbt-core 1.11.2 reportsview_update_via_alteras an unrecognized config key (CustomKeyInConfigDeprecation), and some auth paths emit warnings too. The--warn-errorwas only defense in depth, so this PR removes it. All server-state assertions (column comments and grants) stay.This PR also moves the 1.13.0 release date in
CHANGELOG.mdto Oct 29, 2026.Supersedes #1754.
Verified locally against a SQL warehouse (
databricks_uc_sql_endpoint),tests/functional/adapter/views/test_views.py:uv.lock): 29 passed, 7 skippedChecklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section. (test-only, no changelog entry)This pull request and its description were written by Isaac.