Repository navigation
Fix for Fabric warehouses - #1707
Merged
Merged
Conversation
Looks like Fabric Warehouses are case sensitive. These queries still appear to work on local sql server servers as well.
Added a note about data contracts being pulled from Fabric Warehouses.
# Conflicts: # CHANGELOG.md
On a case-sensitive database such as a Fabric warehouse, the lowercase information_schema.columns does not resolve, so datacontract test fell back to comparing the logicalType and passed physical type checks even against a wrong type. The checks now compare the actual column types there.
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like Fabric Warehouses are case sensitive. These queries still appear to work on local sql server servers as well.
uv run pytest)uv run ruff check --fix && uv run ruff format)