Repository navigation
Conversation
…y-metadata # Conflicts: # CHANGELOG.md
jschoedl
requested changes
Oct 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends #1423 with PostgreSQL catalog-backed key metadata for read-only imports.
PostgreSQL hides constraint metadata from roles that have only application-table
SELECT, forcing users to supplement imports manually even when catalog readsare available.
Catalog access is optional: a role with full-table
SELECT, schemaUSAGE, and catalog read access imports primary and foreign keys. If catalog access is denied, table/column import still succeeds; primary keys fall back toinformation_schemaand foreign keys are omitted. Relationships are retained only when both complete endpoints are included in the selected schema.Evidence
Before: Add Postgres import #1423 read primary keys through
information_schema; a SELECT-only role could receive a usable contract without primary keys, and PostgreSQL foreign keys were not imported.After: Reads declared primary and foreign keys from
pg_catalogwhen available; primary keys fall back toinformation_schemaand foreign keys are omitted when catalog access is denied.uv run --extra dev pytest tests/test_import_postgres.py tests/test_test_relationships.pypasses (36 tests), covering the PostgreSQL 16 SELECT-only role, composite-key atomicity, selected-table and cross-schema cases, plus relationship-test regression coverage.Merge Danger
The change is limited to PostgreSQL import output.
Blast Radius: PostgreSQL
Imported contracts may gain declared primary keys and relationships when the role can read PostgreSQL catalogs; restricted catalog access continues to degrade gracefully.
uv run pytest)uv run ruff check --fix && uv run ruff format)