docs(#1484): document pair-keyed part-to-master invariant in _propagate_restrictions#1494
Merged
Merged
Conversation
…te_restrictions Address MilagrosMarin's review note on #1484: add a method-docstring line noting that under part_integrity="cascade" each restricted Part fires its own upward walk to its Master exactly once, deduplicated per (part, master) pair (not per master).
MilagrosMarin
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses @MilagrosMarin's review note on #1484: the
_propagate_restrictionsmethod docstring didn't mention the pair-keyed dedup invariant — only the inline comment onvisited_part_master_pairsdid. This adds a one-line docstring note that underpart_integrity="cascade"each restricted Part fires its own upward walk to its Master exactly once, deduplicated per(part, master)pair (not per master).Docstring-only; no behavior change.