[JFMGC-54] Report pooled health topology via health_instances - #10
Merged
Conversation
yakavaliou
requested review from
DRMetaplectic,
j1z0,
mariusvilkas and
shackmann
as code owners
August 27, 2026 16:26
shackmann
approved these changes
Aug 27, 2026
shackmann
left a comment
Collaborator
There was a problem hiding this comment.
Very nice. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JointFMClient.health_instances()to probe each configured endpoint independently and report availability, per-instancemax_sample_count, summed parallel capacity, and a compact topology (e.g.1x7000, 1x3000).health()consensus metadata using the minimum reachable cap as the sample-batch size; endpoints remain unaware of each other.healthcommand and document the sum-vs-min distinction in README / API reference.New parameters in the response
Note
Low Risk
Additive public API and CLI output; existing
health()batch-cap and forecast batching behavior is preserved.Overview
Adds
JointFMClient.health_instances()and publicInstanceHealth/HealthInstancestypes so callers can see per-deployment probe results when usingJOINTFM_DEPLOYMENT_IDS(or a single endpoint).Health probing is unified:
health()still returns consensusHealthMetadatawithmax_sample_count= minimum reachable cap (sample-batch size for forecasts);health_instances()lists every configured peer (including failures), sums reachable caps as parallel capacity, and exposestopology/topology_label(e.g.2x5000). The pool’sPoolHealthGateandprobe_health()now attach per-peer outcomes; caching stores both consensus and instance rows.The
jointfm-client healthCLI printsinstances,topology, and top-levelmax_sample_count(sum, distinct fromservice.max_sample_count). README and API reference document the min-vs-sum distinction.Reviewed by Cursor Bugbot for commit 085951d. Bugbot is set up for automated code reviews on this repo. Configure here.