Skip to content

Add student to ARIN 6900 - #6

Merged
arpitnarechania merged 4 commits into
datavisards:mainfrom
nok-ust:chore/add-member
Oct 6, 2026
Merged

arpitnarechania merged 4 commits into
datavisards:mainfrom
nok-ust:chore/add-member

Conversation

@nok-ust

@nok-ust nok-ust commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

The changes in this pull request involves the addition of Nok Chan to ARIN 6900 section under People tab.

@arpitnarechania arpitnarechania self-assigned this Sep 26, 2026
@arpitnarechania

arpitnarechania commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Thanks for submitting this PR. I have a couple comments/edit suggestions before merging.

  • Shouldn't the period be "Fall 2026 · Spring 2027"?
  • Please ensure your entry is indented correctly.

(check the student's entry on the previous line for reference)

@nok-ust

nok-ust commented Sep 26, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for submitting this PR. I have a couple comments/edit suggestions before merging.

  • Shouldn't the period be "Fall 2026 · Spring 2027"?
  • Please ensure your entry is indented correctly.

(check the student's entry on the previous line for reference)

Thanks for the comment, adjust according your requests. You told me you have on going AI student, so I did not change, but I change it now.

@arpitnarechania

arpitnarechania commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Thanks for submitting this PR. I have a couple comments/edit suggestions before merging.

  • Shouldn't the period be "Fall 2026 · Spring 2027"?
  • Please ensure your entry is indented correctly.

(check the student's entry on the previous line for reference)

Thanks for the comment, adjust according your requests. You told me you have on going AI student, so I did not change, but I change it now.

That student was enrolled from Spring - Summer 2026. I meant isn't YOUR course a six credit course spanning across two semester (Fall 2026 and Spring 2027)? You don't have to change that student's period (which is correct); I was pointing out your period. If your course is only for one semester, then what you have is okay (but please revert that other student's record to what it was before).

@arpitnarechania arpitnarechania left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, and welcome!

@arpitnarechania
arpitnarechania merged commit a6f7fd5 into datavisards:main Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants