Repository navigation
smoke-test: don't hardcode the bundle ID prefix - #12
Merged
Merged
Conversation
Self-builders must use their own team's bundle IDs (see #6), so the registration check no longer hardcodes com.dautov. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the self-builder suggestion in #6.
ExtensionControlleralready derives the extension ID fromBundle.main.bundleIdentifierand the README documents the SIP/notarization limit; the smoke test was the last hardcodedcom.dautovcheck.Closing #6 fully still needs the first notarized release (the README's source-build note points users to it).
🤖 Generated with Claude Code