ServiceWorker and reload prompt - #111
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new ServiceWorker, which provides some useful new functionality. Specifically, UI is cached locally, so things like opening settings modals will no longer fail if the server gets updated while the page is loaded. Also, you will be notified to refresh the page if the server has been updated with a newer version:
This is especially helpful when the app is "installed" (e.g. "Add to home screen" on iOS/iPadOS, "Install and create shortcut..." on Android, etc) and the app shell does not provide a refresh/reload control.
Additionally, the switch to Vite PWA also simplifies managing the manifest and icons.