Support for kea 2.0.2

[aasay]

First off, I am loving this project. It is going to work very well for what I need to use it for.

I had to modify your code slightly to get this to work with kea 2.0.2. It looks like support for getting a lease using hwaddr, client_id, and subnet_id was removed so I had to comment out this section in lease_mgr.cc

else if (!addr && hwaddr != 0 && client_id != 0 && have_subnet_id) {
// Lease4Ptr getLease4(const ClientId &client_id, const HWAddr &hwaddr, SubnetID subnet_id)
ClientIdPtr clientid_ptr = ClientId::fromText(client_id);
HWAddr hw = HWAddr::fromText(hwaddr);
ptr = self->mgr->getLease4(*clientid_ptr, hw, subnet_id);
}

I have also added a couple class methods to simplify a few of the tasks that I have to do. If you are interested I can send those back to you or I can fork your code and add them there.

[davejohncole]

If you are actively using the code then you should probably fork the project. I am not using kea in my current job, so you actively using the code means you are in a better situation to make sensible enhancements and modifications.

…

On Fri, Apr 29, 2022 at 7:10 AM Adam Asay ***@***.***> wrote: First off, I am loving this project. It is going to work very well for what I need to use it for. I had to modify your code slightly to get this to work with kea 2.0.2. It looks like support for getting a lease using hwaddr, client_id, and subnet_id was removed so I had to comment out this section in lease_mgr.cc else if (!addr && hwaddr != 0 && client_id != 0 && have_subnet_id) { // Lease4Ptr getLease4(const ClientId &client_id, const HWAddr &hwaddr, SubnetID subnet_id) ClientIdPtr clientid_ptr = ClientId::fromText(client_id); HWAddr hw = HWAddr::fromText(hwaddr); ptr = self->mgr->getLease4(*clientid_ptr, hw, subnet_id); } I have also added a couple class methods to simplify a few of the tasks that I have to do. If you are interested I can send those back to you or I can fork your code and add them there. — Reply to this email directly, view it on GitHub <#6>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABUSDEDWQONX2OF7SUO434TVHL5ELANCNFSM5UTYSINA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[jpisard]

I have the same issue
if aasay fork i will submit sample python to use this module with saltstack
i use several functions to manage our kea servers

[aasay]

https://github.com/invite-networks/kea_python

I already made the changes to support 2.0.2.

[davejohncole]

If more than a few people are using this project then forking might be counter-productive. I really did not know that anyone was using this code. I am willing to put in the effort to consolidate patches if that is your preference.

…

On Fri, May 6, 2022 at 8:08 AM None ***@***.***> wrote: I have the same issue if aasay fork i will submit sample python to use this module with saltstack i use several functions to manage our kea servers — Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABUSDEESCGIN3SI3OPXODR3VIRBFJANCNFSM5UTYSINA> . You are receiving this because you commented.Message ID: ***@***.***>