Skip to content

Lambing ceremony 2/3: forecast marks, first-of-kind tier, skip - #22

Closed
deadp wants to merge 2 commits into
complete-gamefrom
queue/q554
Closed

deadp wants to merge 2 commits into
complete-gamefrom
queue/q554

Conversation

@deadp

@deadp deadp commented Oct 26, 2026

Copy link
Copy Markdown
Owner

Replaces #21 (includes step 1). Marks beside each stamped swatch: tick where the lamb matched the forecast, soft marker where it differed, no digits.
First-of-kind lambs (first true blue, first of a rare wool) get a warm glow and a longer chime; ordinary lambs stay quiet.
Skip button and a remembered 'Short lambing' setting (localStorage, not the save).
Tests in ui/ceremony.test.ts. npm test and typecheck pass. No screenshots taken (step 3).
Left out scratch files (not committed): scratch_edit.py

Queued from the dashboard (item 554). The request:

Goal (proposal 64, lambing ceremony, step 2 of 3): build on step 1 (PR #21, branch queue/q550, head ddeb88a: arrival animation, swatch stamp, mute). START FROM branch queue/q550 so this PR carries step 1 too; say "replaces #21" in the PR body. Presentation only, using the lambing results and forecast data the game already records.
Do: (a) forecast against result: beside each lamb's stamped swatch show what the forecast said, with a tick where the lamb matched and a soft marker where it differed; plain words, no digits (numbers stay locked behind their unlock); (b) celebration tiers: ordinary lamb = the quiet arrival from step 1; first of its kind (first true blue, first of each rare wool, using the existing seen-first tracking such as rareSeen; do not add save fields, use existing state or derive from the report) = a bigger moment (longer chime, a warm glow); keep tiers rare so rare moments stay special; (c) a compact view: a clear way to skip or shorten the ceremony for fast players (a Skip control, and a setting remembered with the existing UI settings, not in the save file).
Keep: mute, no sound before the first tap, reduced motion respected.
Done when: PR open, npm test and typecheck pass, tests cover the tier choice (ordinary vs first-of-kind) and the match/differ marker; PR body says what Joshua will see. If you can render screenshots embed them; if not, say so (step 3 captures).
Do not touch: genetics, balance or config values, chapter ladder (PR #20 is separate), sim

Opened by the queue runner on LXC 113. Merged once CI checks pass and the reviewer's verdict is recorded, unless it touches a hard line (qrunner/hardlines.toml): then it waits for Joshua's yes on the dashboard.

🤖 Generated with Claude Code

Queue runner and others added 2 commits October 26, 2026 21:54
@deadp

deadp commented Oct 26, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #23

@deadp deadp closed this Oct 26, 2026
deadp added a commit that referenced this pull request Oct 26, 2026
…#23)

* Lambing reveal: soft chimes, swatch stamps, mute control

* Lambing ceremony step 2: forecast vs result marks, first-of-kind tier, skip and short lambing

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Ceremony: real tier and hit/miss tests; stop queued chimes when the report closes

---------

Co-authored-by: Queue runner <queue-runner@noreply.invalid>
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant