Repository navigation
Stop storing unlocked volume keys in the case file - #5
Merged
Merged
Conversation
DROP TABLE alone leaves the key bytes in free pages and the journal; zero them with secure_delete and rewrite the file with VACUUM, once, only when an old volume_keys table is present. The test no longer vacuums for itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
deadp
added a commit
that referenced
this pull request
Oct 22, 2026
Co-authored-by: Queue runner <queue-runner@noreply.invalid>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the volume_keys table, save/get/forget_volume_key and the restore-on-open path; unlocked state is now session memory only.
Opening a case drops any legacy volume_keys table.
Replaced the old key-storage test with one checking a legacy table is dropped and no key bytes remain in the case folder.
Full test suite passes (1408 passed, 14 skipped).
Queued from the dashboard (item 308). The request:
Opened by the queue runner on LXC 113. The runner squash-merges this once CI checks pass.
🤖 Generated with Claude Code