Repository navigation
chore(providers): remove the GPL holehe provider - #137
Merged
Merged
Conversation
holehe is GPL-3.0 and the browser service is to become closed source. Remove the /v1/holehe route, models, scraper, dependency (and the packages only it pulled in), the Go provider, browserclient method and types, defaults, provenance, catalog, registry and contract fixtures, and the live docs. A stored workbook chain that still names holehe is now skipped as unknown_provider instead of failing the run or stopping the waterfall. Signed-off-by: Shimul Debnath <270455167+velixio@users.noreply.github.com>
|
All contributors on this pull request have signed the OpenGTM CLA. Thank you! Agreement: OpenGTM CLA 1.0
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / why
Removes the
holeheemail provider entirely. holehe is GPL-3.0, and the owner wants the browser service to be closable later (part of the closed-source audit in PR #135). The other email verifiers (mailscout, abstract_api, debounce, reacher) stay.Removed
scrapers/holehe_check.py, the/v1/holeheroute and import, theHolehe*models, the holehe entry inscripts/record_contract_fixtures.py, the holehe tests, and theholehedependency.uv lockalso dropped the packages only it pulled in (attrs, bs4, outcome, sniffio, sortedcontainers, termcolor, tqdm, trio).config.pyhad no holehe settings.holeheprovider (library.go,register.go,vectors_test.go,unit_test.go), theBrowserinterface method, the browserclientHolehemethod and types and their tests, the recordedholehe.jsonfixture and the holehe op instats.json, and the holehe path/schemas inopenapi.json(regenerated from the service).email_confidence/email_verifydefaults,provenance.go,native_costs.go,wbregistry/registry.json(provider and themailscout, holeherecipe waterfall), contractproviders*.json, and the scrape, vendorcatalog, workbook and provider-inventory vectors.apps/docs(waterfalls, providers) anddocs/go-port/runbooks/browser-service.md. Historical docs (plans, inventory, internal, research) are untouched.Stored configs that still name holehe
holehe(no hits in migrations or settings). The only seeds were the in-code defaults above. No DB migration is needed or included.holehe, the run plan records a cost of 0, then the runner returnsErrUnavailable, which failed the whole run (the job is handed back). The plan builder, when native providers are off, refuses the run outright.workbook/cell.go, a free provider that is neither Go-native, nor in the payload manifests, nor served by the runner is skipped asunknown_providerand the waterfall continues with the next provider. A priced provider with no runner keeps its existing path (spend released, cell fails). Test:TestStoredChainNamingRemovedProviderIsSkipped(integration).Verification
apps/browser-service:uv lock --check,uv sync --frozen,ruff check,ruff format --check: clean.pytest -q: 238 passed (including the openapi drift test).apps/backend-go:go vet ./...andgo build ./...clean.go test -count=1 ./...all packages ok.go test -count=1 -tags integrationforworkbook,providerrun,runplan,api,browserclient,providers/...,vendorcatalog,wbregistry: all ok, run against a freshly migrated scratch database. No-race.git grep -in holehe: only the historical docs, plus one explanatory comment inworkbook/cell.go.