docs(#494): update logpoint support + attach adapterConfig docs to post-#469/#466 reality - #506
Merged
Conversation
#469/#466 reality - set_breakpoint's logMessage schema description now lists Ruby among the fail-fast adapters (#469) and mock among the supported ones, matching the tool-reference table. - tool-reference logpoint table: Ruby moves to the fails-fast row; the "unknown -> validated at launch" row now describes the general dynamically-loaded-adapter mechanism it actually is. - tool-reference attach_to_process: the "adapterConfig is not applied to js-debug attach" sentence contradicted #466 (js-debug attach honors localRoot/remoteRoot/sourceMaps/skipFiles/continueOnAttach); the warning contract now documents both outcomes — dropped keys named as ignored, unrecognized keys forwarded as-is with a did-you-mean. Closes #494 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #494 — three user-facing descriptions still documented pre-#469 / pre-#466 behavior, two of them in the MCP tool schema itself (the text an agent reads to decide what to call).
Changes
set_breakpointlogMessageschema description (src/server.ts): Ruby joins the exclusion list ("not by Java, .NET, or Ruby" — Ruby logpoints silently become pausing breakpoints; list_breakpoints then reports verified:true with the logMessage intact #469 made ruby fail fast), and mock joins the supported list, aligning the schema string with the tool-reference table.docs/tool-reference.mdlogpoint table: Ruby moves into the fails-fast row (with the Ruby logpoints silently become pausing breakpoints; list_breakpoints then reports verified:true with the logMessage intact #469 rationale); the "unknown — accepted with a warning; validated at launch" row now describes the general dynamically-loaded-adapter mechanism it actually is, instead of being pinned to Ruby.docs/tool-reference.mdattach_to_process: removed the sentence claiming "adapterConfigis not applied to js-debug attach" (it contradicts adapterConfig: unknown keys are accepted silently — a typo of a supported key (pathMapping vs pathMappings) gets no warning #466 —localRoot/remoteRoot/sourceMaps/skipFiles/continueOnAttachdo reach js-debug), and documented both halves of the warning contract: dropped keys named as ignored vs unrecognized keys forwarded as-is with an edit-distance did-you-mean.All three were verified empirically in the issue against
main@ 9a7327a. No behavior changes; grep confirms no test pins the old strings.🤖 Generated with Claude Code