Conversation
This was referenced Sep 13, 2026
MaxRink
force-pushed
the
fix/sb-dev-app-arguments
branch
from
September 14, 2026 08:59
d56e530 to
be286d1
Compare
MaxRink
marked this pull request as ready for review
September 15, 2026 20:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sb-dev startcurrently accepts build-time Dart defines but cannot forward runtime arguments to the app'smain(). Passing--app-argis rejected as an unknown flag. The app already supports--serial,--no-account, and--bypass-onboarding, so the managed development loop cannot currently reproduce the headless launch used by the plugin API smoke tests.Add one repeatable forwarding option and preserve it across
sb-dev restart:Each value becomes a separate Flutter
--dart-entrypoint-args=<value>argument. Here--serialsuppresses BLE discovery; it does not select a particular serial device. The other two flags use existing app behavior to avoid account services and onboarding during an isolated smoke run.The change preserves spaces and shell metacharacters literally across launch and restart, rejects missing values and newlines, and documents the option in the existing development guide. It adds no new application flag.
This is independent developer tooling, not a runtime dependency of the Skale or grinder plugins. Those features can ship without it. Direct
flutter run --dart-entrypoint-args=...is an existing alternative; forwarding throughsb-devlets the same scenario retain the project's managed start, readiness, reload, restart, and cleanup workflow.Linked Issue
Related #856. This is independent development tooling used by the #846/#848 smoke scenarios; closed #809 is historical context only.
The new discussion issue is awaiting maintainer triage. This PR remains a draft while maintainers discuss the proposal; opening the issue does not satisfy the accepted-issue gate or imply approval of the proposed contract.
Verification
Combined Linux Flutter gate for the current publication stack: 4,315 passed, 1 skipped, 0 failed; analyzer clean (48.0s). Source was unchanged during the gate.
Managed Linux runtime passed
--serial,--no-account, and--bypass-onboardingthrough application launch and reload; the app logs confirmed each forwarded argument.Managed Linux runtime passed
--serial,--no-account, and--bypass-onboardingthrough application launch and reload; the app logs confirmed each forwarded argument.Impact
Developers and CI scenarios can launch the app with explicit arguments without modifying source or onboarding state. Existing invocations remain compatible; this is a development tooling change with no REST/WS contract change.
Contributor Responsibility
AI-assisted development is allowed. The submitter remains responsible for the submitted work.