Skip to content

deepin: config: arm64: disable pseudo-NMI support - #2153

Merged
opsiff merged 1 commit into
deepin-community:linux-6.6.yfrom
opsiff:linux-6.6.y-2026-09-16-patches
Sep 16, 2026
Merged

opsiff merged 1 commit into
deepin-community:linux-6.6.yfrom
opsiff:linux-6.6.y-2026-09-16-patches

Conversation

@opsiff

@opsiff opsiff commented Sep 16, 2026

Copy link
Copy Markdown
Member

Drop CONFIG_ARM64_PSEUDO_NMI from the arm64 desktop defconfig.

This option builds support for NMI-like interrupts using GIC interrupt priorities. Even though pseudo-NMI mode still requires the runtime irqchip.gicv3_pseudo_nmi=1 parameter before high-priority interrupts are used, enabling the Kconfig option keeps the priority-masking code paths compiled in for arm64 exception and interrupt handling.

When the option is enabled, the kernel has to support PMR-based IRQ masking through ICC_PMR_EL1, save and restore the PMR state in exception entry code, and branch through pseudo-NMI-aware IRQ handling paths. That adds overhead to hot interrupt/exception paths and can reduce performance on desktop systems that do not need pseudo-NMI diagnostics.

Leave it disabled by default for the deepin arm64 desktop configuration.

Improved unixbench benchmark by 0.5%.

Summary by Sourcery

Enhancements:

  • Disable ARM64 pseudo-NMI support in the deepin desktop defconfig to reduce interrupt and exception handling overhead on systems that do not require it.

Drop CONFIG_ARM64_PSEUDO_NMI from the arm64 desktop defconfig.

This option builds support for NMI-like interrupts using GIC interrupt
priorities. Even though pseudo-NMI mode still requires the runtime
irqchip.gicv3_pseudo_nmi=1 parameter before high-priority interrupts are
used, enabling the Kconfig option keeps the priority-masking code paths
compiled in for arm64 exception and interrupt handling.

When the option is enabled, the kernel has to support PMR-based IRQ masking
through ICC_PMR_EL1, save and restore the PMR state in exception entry code,
and branch through pseudo-NMI-aware IRQ handling paths. That adds overhead to
hot interrupt/exception paths and can reduce performance on desktop systems
that do not need pseudo-NMI diagnostics.

Leave it disabled by default for the deepin arm64 desktop configuration.

Improved unixbench benchmark by 0.5%.

Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
@sourcery-ai

sourcery-ai Bot commented Sep 16, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The arm64 desktop defconfig no longer enables CONFIG_ARM64_PSEUDO_NMI, avoiding pseudo-NMI-related code and hot-path overhead while retaining the default configuration for systems that do not use pseudo-NMI diagnostics.

File-Level Changes

Change Details Files
Disable pseudo-NMI support in the deepin arm64 desktop kernel configuration.
  • Remove CONFIG_ARM64_PSEUDO_NMI from the defconfig so PMR-based masking, PMR exception-state handling, and pseudo-NMI IRQ paths are not compiled by default.
  • Target reduced interrupt and exception-path overhead for desktop systems without pseudo-NMI requirements; the reported UnixBench improvement is 0.5%.
arch/arm64/configs/deepin_arm64_desktop_defconfig

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The configuration change correctly disables an option that defaults to off and matches the stated purpose.

Pull request overview

Disables arm64 pseudo-NMI support in the Deepin desktop kernel configuration to reduce interrupt-path overhead.

Changes:

  • Removes CONFIG_ARM64_PSEUDO_NMI=y from the arm64 desktop defconfig.
File summaries
File Description
arch/arm64/configs/deepin_arm64_desktop_defconfig Disables pseudo-NMI support.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@opsiff
opsiff merged commit dd31aa0 into deepin-community:linux-6.6.y Sep 16, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants