Repository navigation
A same name under two undeclared classes queues a review, so ACME-1 typed as a ticket and a work item is not split in silence - #1445
Open
rudycelekli wants to merge 2 commits into
Conversation
…yped as a ticket and a work item is not split in silence Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
Contributor
|
Thanks for the fixes. Reviews of #1429–#1445 are on hold until the open change requests are answered: #1398, #1399, #1403, #1405, #1407, #1411, #1412, #1413, #1414, #1415, #1418, #1421, #1422, #1423. Once those are done, please group fixes that touch the same function into one PR before asking for review. (#1444 overlaps Floating-Y's #1449, which covers the same restore case; it will likely be closed in favour of that one.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mention and an existing entity can share a name while their classes are not declared disjoint, not in one branch of the hierarchy, and not in the short confusable list. Resolution kept both entities and queued no review pair. It still keeps them apart, and now queues a type_drift review.
No shipped ontology pack declares disjointness, so a same-name match across two classes now queues a review pair, capped at 4 pairs per mention.
Relates to #1338.