Repository navigation
A model card's Test button tests only that card - #1447
Conversation
Signed-off-by: 0xvectr <57480598+0xvectr@users.noreply.github.com>
WaylandYang
left a comment
WaylandYang
left a comment
There was a problem hiding this comment.
Welcome, and thanks for picking this up! The backend is exactly what #1424 asked for: ?card= is validated, only that card is probed, and a call without it still tests all four. One thing on the page: the Save buttons (and field edits) still call resetTests(), so saving the OCR card clears a fresh result on the chat card. Could each save/edit reset only its own card's test (chat + embed for presets)? A Settings.test.ts case for that would be welcome. Small extras: mention card in the doc comment on test, and please retitle to a sentence, e.g. your commit headline "A model card's Test button tests only that card". Then it's good to merge.
Signed-off-by: 0xvectr <57480598+0xvectr@users.noreply.github.com>
0xvectr
changed the title
|
Done: saving or editing a card, or switching the OCR provider, now resets only that card's test (chat and embed for presets), with a |
WaylandYang
left a comment
WaylandYang
left a comment
There was a problem hiding this comment.
Thanks @0xvectr, that's exactly it: a save or an edit now expires only its own card's test, a preset expires chat and embed, and cardsOf is covered. Approving and merging.
The model settings test endpoint now takes ?card= and the page sends the card that was clicked, so pressing Test on one card no longer runs all four probes. A request without card still tests all four.
Closes #1424