Repository navigation
Conversation
Signed-off-by: Virtue039 <virtue039@qq.com>
…ation-quotes Signed-off-by: Virtue039 <virtue039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The adjudicator's
quotestool silently discarded every other quotation from the same chunk. In a recorded namesake failure, the graph contained both the finance director's management-award sentence and the engineer's technical-award sentence, but repeated source lookups returned only the first sentence.Deduplicate by chunk and rendered quotation instead. Return the first passage from each chunk before additional passages, retain ordinary-fact priority over name evidence, and keep the existing caller limit (six passages) and output clipping. Duplicate facts, invalidated facts and bare-name evidence do not consume additional slots. No model prompt, adjudication trigger, confidence gate, schema or extraction protocol changes.
Validation on macOS arm64, current head
82c60d530f920183c336aa28129b56a1f4b6fbe6, merged with dev1d94b532860ba7e60888f75449367da9388b1ab0after #1425 and #1377 landed:82c60d5(run41011095162).apply_verdict. Initial request messages match the recording on both builds. Before: one award quote. After: both award quotes reach the actual model request. Both runs make six scripted calls.Fresh investigation pilot (not a corpus benchmark): fixed
qwen3.7-flash-2026-07-15, thinking disabled, temperature 0; four restored-state investigations in baseline/fix/fix/baseline order with identical initial requests. Both baseline runs merged at 0.95. The fix runs yielded one merge at 0.95 and onedifferent(0.5)left pending human review. All four runs skipped the quotes tool, so the observed variation cannot be credited to this query fix. Seven successful calls, 18,350 tokens; connectivity preflight 17 tokens separate. All results retained, no selective reruns. This pilot froze the earlier heads1142792/a6b758d; it is not a measurement of the newly integrated head.This does not establish an identity-quality improvement. Replaying the original erroneous
same(1.0)response still merges in both versions; the control is intentionally not changed to a successful answer. The upstream name-only extraction has already put two people's awards on one entity, which this source-retrieval fix cannot split. No 16-KB comparison has been run for this change. Additional passages may increase input tokens within the existing output bound. Keep draft until the remaining evaluation/review questions are resolved.Related: #1193, #1136. Neither issue is closed by this PR. #1456 remains a separate failed-acceptance draft (wrong merges 15→23); this patch does not rehabilitate its measurements.