Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The macOS model-viewer distribution loses its documented asset-path argument when the launcher restarts the JVM.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Upgrades the build and dependency stack to Java 25/Gradle 9.8 while consolidating Cake desktop packaging.
Changes:
- Centralizes versions, repositories, toolchains, and launcher build configuration.
- Modernizes JVM, runtime-image, and Graal native distributions.
- Updates CI, documentation, and CSV-loading tests.
| File | Description |
|---|---|
.github/workflows/build.yml |
Upgrades CI actions and Java. |
AGENTS.md |
Updates build/test requirements. |
README.md |
Documents Java 25 requirement. |
build.gradle |
Centralizes plugins and toolchain configuration. |
cake/README.md |
Documents distribution workflows. |
cake/cake-client/build.gradle |
Uses shared desktop configuration. |
cake/cake-client/nativeimage.gradle |
Removes duplicated native configuration. |
cake/cake-client/src/main/kotlin/org/demoth/cake/lwjgl3/Lwjgl3GameLauncher.kt |
Updates displayed version. |
cake/cake-modelviewer/build.gradle |
Uses shared desktop configuration. |
cake/cake-modelviewer/nativeimage.gradle |
Removes duplicated native configuration. |
cake/cake-modelviewer/src/main/kotlin/org/demoth/cake/lwjgl3/Lwjgl3ModelViewerLauncher.kt |
Updates displayed version. |
cake/core/build.gradle |
Removes unused dependencies and simplifies plugins. |
cake/core/src/main/resources/META-INF/native-image/org.demoth/cake/reachability-metadata.json |
Registers audio constructors for native images. |
cake/desktop.gradle |
Adds shared desktop packaging configuration. |
cake/engine-tools/build.gradle |
Enables native access. |
cake/nativeimage.gradle |
Adds shared Graal configuration. |
game/src/main/java/jake2/game/items/GameItems.java |
Adapts to the updated CSV API. |
game/src/test/java/jake2/game/items/GameItemsTest.java |
Adds CSV-loading assertions. |
gradle.properties |
Enables configuration cache and removes version properties. |
gradle/libs.versions.toml |
Upgrades and centralizes dependencies/plugins. |
gradle/wrapper/gradle-wrapper.jar |
Updates the Gradle wrapper binary. |
gradle/wrapper/gradle-wrapper.properties |
Selects and verifies Gradle 9.8. |
gradlew |
Updates the POSIX wrapper script. |
gradlew.bat |
Updates the Windows wrapper script. |
settings.gradle.kts |
Enforces centralized Maven Central repositories. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.