chore: release 1.2.0 - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The session file (
~/.dpctl.config) holds a live access key and was written with the default mode, so anyone else on the machine could read it. It's now written at 0600, via a temp file and rename so an interrupted write can't truncate it. It's also repaired on read, not just on write: anyone already logged in never takes a write path again, so otherwise their key would stay world-readable forever.dpctl now sends a
User-Agent. Node's superagent sends none of its own, and the API and dashboard already expectdpctl/1.2.0(rest-headers.ts says as much in a comment), so without it every CLI login shows up nameless in Recent Logins.Then the release itself: version, npm keywords, and
files: bin/** -> bin/script/**, which was shipping the compiled tests to everyone who installed. README now leads withnpm install -g @deploypulseio/dpctlinstead of telling people to clone the repo.