fix: error messages - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dpctl deployment errorsreported an all-clear for a name that doesn't exist. The reports route answers an unknown app with an empty list rather than a 404, so a typo looked exactly like a healthy deployment, and a CI job checking for failures would have read it as a pass. It now confirms the deployment exists before saying there are no failures, and only pays for that check when the result is empty.Server errors printed as raw JSON:
[Error] {"message":"This access key is read-only..."}. Three places were unwrapping the envelope and disagreeing about how; they now share one helper. Read-only keys hit this constantly, so it showed up on every refused write.dpctl org,dpctl appand five other bare category commands printedArgument check failed: (argv) => isValidCommandunder the usage block..fail()deduped only identical messages, so the arity complaint and the check's stringifiedsource both got through.