Repository navigation
Upgrade TinyAuth for CakePHP 6 - #172
Merged
Merged
Conversation
Pull @param/@return/@var down to native PHP 8.2 types across src/. Signatures and properties only, no behaviour change. Kept the docblocks where they hold generics native types can't (array<string, int|string>). Left a few loose on purpose where a strict type would break callers: persistIdentity, hasRoles, link/_default. phpstan 8 + cs green, tests unchanged.
Owner
|
I like it, but some of the public API changes here need to wait until the next major. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dereuromark
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate the existing native typing changes into the CakePHP 6 branch and retain the latest ACL, cache isolation and command fixes from CakePHP 5.
Update configuration, component registry, helper view and DebugKit panel properties to the CakePHP 6 APIs. Commands receive arguments and console IO through framework properties, and shared ACL utilities accept
ConsoleIoInterface.Require PHP 8.5, CakePHP 6, Authentication 5, Authorization 4, DebugKit 6 and PHPUnit 13. The CakePHP 5 branch remains unchanged.
Validation: 167 tests with 511 assertions, coding standards, PHPStan level 8 and the documentation build pass.