Fix SeparatePanel fullscreen origin by clearing WA_Moved - #343
Open
anriltine wants to merge 1 commit into
Open
Conversation
RpWidget's zero setGeometry sets WA_Moved, so Qt treats the panel as explicitly positioned and showFullScreen() only resizes. Clear that attribute first, matching the Linux transient-parent workaround. Fixes telegramdesktop/tdesktop#30963. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
Author
|
@ilya-fedin this is the clean follow-up to #342 using |
Contributor
|
You checked it works, right? |
Author
|
No, included the test plan) |
Contributor
|
Please tell when you have checked it works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Qt::WA_MovedonSeparatePanelbeforeshowFullScreen(), so Qt can place the frameless Mini App panel at the screen origin instead of only resizing it.initGeometry(), which already clearsWA_MovedafterRpWidget's constructorsetGeometry(0, 0, 0, 0).Context
Reported in telegramdesktop/tdesktop#30963 (also #31041 / #31114).
This supersedes #342. That PR forced screen geometry after
showFullScreen()and blamed QTBUG-39537 / QTBUG-86899. @ilya-fedin pointed out those bugs are unrelated/fixed, and that the real issue is likely ours: Qt only auto-positions unlesssetGeometry()/move()were called, soWA_MovedfromRpWidgetkeeps Mini Apps anchored at the pre-fullscreen origin.Forcing
SetGeometryAndScreen()aftershowFullScreen()is also the wrong tool:setGeometry_sys()clearsQt::WindowFullScreenwhen not insidesetWindowState().Test plan
web_app_request_fullscreen— panel should cover the full screen from the monitor origin.Made with Cursor