Use inline block for digits - #355
Merged
Merged
Conversation
mikehaverstock
approved these changes
Jul 29, 2026
mikehaverstock
left a comment
Member
There was a problem hiding this comment.
Have you verified this doesn't change anything meaningful with rendering? We could, for instance, fire off a job to compare a lot of latex rendering to make sure it's pixel perfect. I'm not good enough with css to know why this is obviously only a performance optimization and not going to change layout.
Member
|
How did you come up with this? |
Author
|
Removed all the digit classes and saw the performance was good, then bisected what styles could be the culprit to determine that removing the margins would fix up performance. I then brainstormed a few possible alternatives to using margins:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves performance in Chrome. Something about the negative margins made Chrome take quadratic time in the layout step. This is part of why 10k element lists were really slow. After this PR, they should take closer to 1 second to render, rather than 1 minute.
The negative margins were the lines below used for digit grouping, like
margin-right: @contract-margin;(since contract-margin is-0.009em).