ci: give main a run-unique concurrency group - #113
Conversation
Every push to main shared one ref-keyed concurrency group with cancellation on, so a merge landing while the previous merge's checks were still running evicted them. A cancelled check is not a failed check, so main settled green over verification that never completed. Disabling cancellation would not be sufficient on a shared key: a group holds one running plus one pending run, and a third push cancels the pending one. Part of devantler-tech/monorepo#2690
Requesting review at Same change as the merged siblings devantler-tech/kyverno-policies#35 and devantler-tech/platform#2992. The group is keyed on @coderabbitai review |
|
✅ Action performedReview finished.
|
📝 WalkthroughWalkthroughThe CI workflow now uses branch-specific concurrency settings. Main-branch runs use unique run IDs and are not cancelled when another run starts. Pull-request runs continue to use ref-based grouping and cancel previous in-progress runs. Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ReadinessProgrammatically tested. CI settled at Reviewed. Green CodeRabbit at the current head — "No actionable comments were generated in the recent review", naming the reviewed range ending at Tried and evaluated as a user — with the limit stated. The changed behaviour only manifests on push to The default-branch half — two closely-spaced pushes to Promoting on that basis. |
Why
maincan report green on checks that never finished. Every push tomainshared one concurrency key with cancellation enabled, so a merge landing while the previous merge's checks were still running evicted them — and a cancelled check is not a failed check, so the commit status settles green regardless.This repository publishes the plugin marketplace that the agent deployments install from, so an unverified regression on
mainreaches every consuming runtime.What
Runs on
maineach get their own key, so nothing there queues behind or evicts anything else. Pull-request runs are unchanged — superseded ones still cancel.Part of devantler-tech/monorepo#2690