Skip to content

Bump bundled diffr to 0.1.8 - #818

Merged
thesiti92 merged 1 commit into
mainfrom
chore/diffr-0.1.8
Sep 30, 2026
Merged

thesiti92 merged 1 commit into
mainfrom
chore/diffr-0.1.8

Conversation

@thesiti92

Copy link
Copy Markdown
Contributor

Fixes #805.

diffr 0.1.8 (devdotfast/diffr#61) reads working-tree files through Git's clean filters. Under core.autocrlf=true, a CRLF checkout was compared raw against LF blobs, so plain-text files such as Markdown showed every line as changed.

  • Pin @dev.fast/diffr 0.1.8 in Review, Desktop and review-protocol; update the lockfile and release-age exception.
  • diffr 0.1.8 removed --config: the summarizer test writes diffr/config.toml under a temp dir and sets XDG_CONFIG_HOME to it. The fake diffr in diffr-config.test.ts follows.

Validation:

  • Issue repro through structuralDiff (worktree comparison): notes.md 200/200 changed lines on 0.1.7, 0 lhs / 1 rhs on 0.1.8; right side no longer carries \r.
  • 14 bundled-diffr integration tests against the fetched 0.1.8 release; review-protocol tests (59); diffr-config and structural-diff tests; root lint and format; typecheck for review, review app and review-protocol; Desktop protocol sync unchanged.
  • No native Desktop UI run.

diffr 0.1.8 reads working-tree files through Git's clean filters, so a
CRLF checkout under core.autocrlf no longer shows every line of a
plain-text file (e.g. Markdown) as changed.

0.1.8 also drops diffr's --config flag; the summarizer test now points
XDG_CONFIG_HOME at its temporary config instead.

Fixes #805.

Agent-Session: 459ae7ec-7302-42c5-b473-4e315a7e4e19
Agent-Session: 203ee435-a867-494c-bb56-ddde9edf962e
Agent-Session: 78694b58-9718-40bf-a6b8-661e21afe339
Agent-Session: a9cd3da4-c06c-4d2b-b8e8-e71439cee705
Agent-Session: 0e24d827-3a5e-4ed7-aa02-bbda8d39a5e0
@thesiti92
thesiti92 merged commit 2ccccb7 into main Sep 30, 2026
1 check passed
@thesiti92
thesiti92 deleted the chore/diffr-0.1.8 branch September 30, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Diff view counts view every line of a CRLF Markdown file as changed in worktree reviews

2 participants