Feat/bottom nav and chips - #2
Open
suung wants to merge 3 commits into
Open
Conversation
Extract iconMap to icon-map.ts, alias gear/trash/x/house/person, and add climate-friendly names (tree, map, heat, shop, …) so WireMD shortcodes match skills docs and Adapt Now screens. Bump to 0.1.9.
Implements the documented mobile tab bar (::: bottom-nav with nested
nav), removable/static chips via |.chip|, and segmented controls via
row {.toggle-group}, with shared structural CSS across themes.
ICON_MAP now returns plain/monochrome Unicode symbols (or an empty glyph, label-text-only) instead of colored pictograph emoji for every :name: shortcode. Kept the handful of already-monochrome symbols (check, close, arrows, gear, social marks) as-is. Fixes resolveIcon() falling back to the default bullet for icons intentionally left blank (switched || to ?? so empty string isn't treated as falsy). Updated renderer/tailwind/react renderer tests to assert the specific former emoji are gone rather than expecting them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Type of Change
Related Issues
Fixes #
Related to #
Changes Made
Testing
Test Coverage
npm test)Manual Testing
Examples
Input
<!-- wiremd input example -->Output
<!-- or describe the output/behavior -->Checklist
Breaking Changes
Migration Guide
<!-- How users should update their code -->Screenshots/Recordings
Performance Impact
Documentation
Additional Notes
Reviewer Checklist