Repository navigation
chore: remove Smithery publishing - #369
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
|
|
Failed to generate code suggestions for PR |
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".github/workflows/publish.yml" line_range="388-429" />
<code_context>
- publish-smithery:
</code_context>
<issue_to_address>
**Smithery releases stop publishing**
When a release tag is published, the release workflow no longer builds or publishes a Smithery bundle, so tagged releases stop updating the Smithery listing.
Reconcile the Smithery-shipping requirement with the retirement: retain a supported publishing path or remove Smithery from the knowledge entry if retirement is intended.
</issue_to_address>There was a problem hiding this comment.
The Robin Hood of code review
Heads up: this is a point-in-time review. Push fixes freely, then comment
/robinwhenever you want another pass.
✅ No issues found
Summary
The Smithery publishing integration has been deliberately removed after Smithery rejected server updates (403 errors) on v0.8.4. The publish-smithery job, packaging/smithery/build.py, and associated tests have been cleanly removed. Documentation (CHANGELOG, README, docs) has been updated to reflect this change, and the remaining CI/CD pipeline (publish-hf-space, publish-mcp-registry, publish-ghCR) is unaffected.
Smithery rejects server updates (403: Updating servers has been removed), which failed the publish-smithery job on v0.8.4. Remove the job, packaging/smithery, its test, the README badge/link, and the related docs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
6d9aac4 to
74f0c61
Compare
Smithery rejects server updates (
403: Updating servers has been removed), which failedpublish-smitheryon v0.8.4. Removes the job,packaging/smithery/, its test, README badge/link and related docs. Unit + contract: 3111 passed.Manual follow-ups (not in this PR): delist on Smithery's site; delete the
SMITHERY_API_KEYsecret andPUBLISH_SMITHERYvariable.🤖 Generated with Claude Code
Summary by Sourcery
Retire Smithery publishing and remove its related packaging, workflow, tests, and documentation references.
Bug Fixes:
Enhancements:
CI:
Documentation: