fix: repair the release pipeline and publish the media module - #299
Merged
Merged
Conversation
release:prepare runs "clean verify" over the whole reactor, which now includes the media module. Its CMake configure stops when the FFmpeg submodule is missing, and the prepare-release job never checked it out, so the release failed before any commit or tag was made.
The media module became part of the normal build, and snapshot builds deploy it, but the release workflow never learned about it: the release jobs uploaded only webrtc-jni's natives, and publish-central deployed only the parent and webrtc. A release would have shipped without the artifact the media guide tells applications to depend on. The release jobs now also upload the media module's classifier jar, under a name the natives-* download already merges into the same flat directory. publish-central checks that every platform's media jar is there and deploys the module alongside webrtc. The media module gets the attach-natives-all profile webrtc already has, activated the same way by natives.dir. It attaches the seven downloaded jars and turns off the CMake build and the host natives jar, so publish-central neither needs the FFmpeg submodule nor builds a second, host-only natives jar.
The media guide spelled out 0.19.0-SNAPSHOT, which stops resolving once
0.19.0 is released and the snapshot moves on. It now uses {{ VERSION }}
like the get-started guide, which the release workflow keeps current.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last Release run (36277592533) failed in "Prepare release", and the media module would not have been published even if it had got further. v0.18.0 predates the media module, so none of the CI changes since #291 had been through a release yet.
Changes
release:prepare. It runsclean verifyover the whole reactor, which now includes the media module, whose CMake configure stops with "The FFmpeg submodule is not checked out". The failure came before any commit or tag, so nothing needs undoing. FFmpeg builds out of tree, so the submodule stays clean for the release plugin.webrtc-java-mediawith a release. The release jobs uploaded only webrtc-jni's natives, andpublish-centraldeployed only.,webrtc.natives-media-<platform>, which the existingnatives-*download merges into the same flat directory.publish-centralchecks that all seven media jars are present and deploys.,webrtc,webrtc-java-media.attach-natives-allprofile webrtc has, activated bynatives.dir. It attaches the seven jars and turns off the CMake build and the host natives jar.0.19.0-SNAPSHOT; it now uses{{ VERSION }}like the get-started guide.Verification
mvn package -pl .,webrtc,webrtc-java-media -DskipTests -Dnatives.dir=<dir>with placeholder jars for all 7 classifiers. It succeeded, and the media module ranattach-nativeswithout any CMake ornatives-jarexecution.dryRun: this is the first time the media module goes through the release profile (sources, javadoc, signing).