ipc transport: use Jupyter's {ip}-{port} socket address format #134 - #135
Open
paulk-asert wants to merge 1 commit into
Open
ipc transport: use Jupyter's {ip}-{port} socket address format #134#135paulk-asert wants to merge 1 commit into
paulk-asert wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #134.
For the
ipctransport Jupyter treats the connection file'sipas a base path and names each channel socket{ip}-{port}(that is whatjupyter_clientwrites and what frontends connect to).JupyterSocket.formatAddressused:for every transport, so underipcthe kernel bound…/kernel-abc:1while the client waited on…/kernel-abc-1and the frontend hung at "Connecting".This has been invisible so far because the released JeroMQ (0.6.0) emulates
ipc://over loopback TCP and cannot talk to libzmq clients regardless. JeroMQ master (zeromq/jeromq#998, merged Sep 2024, not yet released) adds real Unix-socket ipc on Java 16+; with that on the classpath this address format was the only remaining failure. Verified end to end in Google Colab's public runtime image (which launches hosted kernels with--transport=ipc): with this change plus JeroMQ master, a jjava-based kernel replies tokernel_infoand executes cells over ipc.Change:
-separator whentransportisipc;tcpunchanged. Unit test added for both cases.