Skip to content

fix(posting): mark removed split parts for reclamation #9825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewmcneely merged 2 commits into from
Oct 20, 2026
+409 −0
Merged

fix(posting): mark removed split parts for reclamation #9825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0841645
fix(posting): reclaim removed split payloads during rollup
KeisukeYamashita Sep 4, 2026
29d4590
refactor(posting): make split cleanup invariants explicit
KeisukeYamashita Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions posting/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1457,6 +1457,7 @@ func (l *List) Rollup(alloc *z.Allocator, readTs uint64) ([]*bpb.KV, error) {
if readTs != math.MaxUint64 {
kv.Version += 1
}
parentVersion := kv.Version

kv.Key = alloc.Copy(l.key)
kvs = append(kvs, kv)
Expand All @@ -1471,8 +1472,23 @@ func (l *List) Rollup(alloc *z.Allocator, readTs uint64) ([]*bpb.KV, error) {
kvs = append(kvs, kv)
}

// At newMinTs, readers still resolve the old parent and need its removed parts.
// Retire them at the parent's version (+1 for finite readTs).
for _, startUid := range l.plist.Splits {
Comment thread
matthewmcneely marked this conversation as resolved.
if _, retained := out.parts[startUid]; retained {
continue
}
part, err := out.marshalPostingListPart(alloc, l.key, startUid, &pb.PostingList{})
if err != nil {
return nil, errors.Wrapf(err, "cannot marshal removed posting list part")
}
part.Version = parentVersion
kvs = append(kvs, part)
}
Comment thread
matthewmcneely marked this conversation as resolved.

// Sort the KVs by their key so that the main part of the list is at the
// start of the list and all other parts appear in the order of their start UID.
// Keep the parent first: crash recovery must not retain tombstones without it.
sort.Slice(kvs, func(i, j int) bool {
return bytes.Compare(kvs[i].Key, kvs[j].Key) <= 0
})
Expand Down
Loading
Loading