fix: stabilize data engine context - #1445
Merged
KaiVandivier merged 2 commits intoAug 23, 2026
Merged
Conversation
|
KaiVandivier
deleted the
fix/prevent-rebuilding-data-engine-plugin-context
branch
August 23, 2026 14:41
dhis2-bot
added a commit
that referenced
this pull request
Aug 23, 2026
## [3.17.4](v3.17.3...v3.17.4) (2026-08-23) ### Bug Fixes * **data-service:** stabilize data engine context ([#1445](#1445)) ([2337108](2337108))
Contributor
|
🎉 This PR is included in version 3.17.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements N/A
Description
This is the problem I hit in the new event-visualizer-app:
postMessage.PluginLoadercallssetPropsFromParent. That re-renders the whole tree inside the iframe.DataProvidersits in that tree. Nothing above it is memoised, so it re-renders too.DataProviderrunsnew RestAPILink(config)andnew DataEngine(link). SouseDataEngine()hands out a different engine object than last render.To avoid this, first we need to ensure
configis as stable as possible, which we do by memoizing what we can in dhis2/app-platform#962. And with this stable config we can produce a stablecontexthere.While the changes in this PR rely on the fix in dhis2/app-platform#962, as well I wouldn't go as far as saying that these two PRs are fully interdependent. This code will run fine without the changes in app-platform. The issue won't be fixed, but it also won't be any worse than things currently are.