feat: [DHIS2-21655] Uncomplete events from view mode - #4649
Open
henrikmv wants to merge 49 commits into
Open
Conversation
henrikmv
changed the title
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
henrikmv
marked this pull request as ready for review
July 22, 2026 11:46
|
🚀 Deployed on https://deploy-preview-4649.capture.netlify.dhis2.org |
…us in relevant components
…_uncomplete-event-view-mode
henrikmv
marked this pull request as draft
August 13, 2026 13:43
…tor related logic
…_uncomplete-event-view-mode
…_uncomplete-event-view-mode
…eEventEditPermissions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DHIS2-21655
Completion behavior — event toggle
Baseline: user has
canEditProgramStage. Without it, the completion action is not shown.blockEntryForm=false)F_UNCOMPLETE_EVENTAND (not expired ¹ ORF_EDIT_EXPIRED)blockEntryForm=true)F_UNCOMPLETE_EVENTAND (not expired ¹ ORF_EDIT_EXPIRED)¹ Expiry rules
"Not expired" = the event's
occurredAtis inside the program's editing window (and, for completed events, the complete-events-expiry window).F_EDIT_EXPIREDbypasses expiry. It does not bypassF_UNCOMPLETE_EVENT— the two authorities are additive.Behavior when
blockEntryForm=trueand event is COMPLETEDThe form is read-only ("This event has been completed"). To edit values, the user must Uncomplete first (requires
F_UNCOMPLETE_EVENT), edit, then re-Complete.Hook flag
canToggleCompletionreturned fromuseEventEditPermissions— replaces the previouscanUncompleteEventand generalizes it to cover both Complete (ACTIVE→COMPLETED) and Uncomplete (COMPLETED→ACTIVE) transitions.