fix: [DHIS2-18620][DHIS2-21937] Hidden TEA is displayed in the TEI profile - #4704
Open
henrikmv wants to merge 29 commits into
Open
fix: [DHIS2-18620][DHIS2-21937] Hidden TEA is displayed in the TEI profile#4704henrikmv wants to merge 29 commits into
henrikmv wants to merge 29 commits into
Conversation
|
🚀 Deployed on https://deploy-preview-4704.capture.netlify.dhis2.org |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…l rule effects are ready
…t-infinite-loading-without-org-unit' into hv/fix/DHIS2-18620_hidden-TEA-displayed-in-TEI-profile
henrikmv
marked this pull request as draft
August 18, 2026 14:29
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…e handling in useRuleEffects
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
henrikmv
changed the title
henrikmv
marked this pull request as ready for review
August 21, 2026 09:35
… WidgetProfile components
henrikmv
marked this pull request as draft
August 26, 2026 08:05
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DHIS2-18620 and DHIS2-21937
This PR fixes three bugs:
HIDE_FIELDprogram rules had no effect on the TEI profile widget becauseruleEffectswere never wired through toWidgetProfile.Architectural change: Instead of passing
ruleEffectsas props through the component tree, enrollment-scoped rule effects are now evaluated once via a newuseEnrollmentScopeRuleEffectshook and dispatched to Redux. All consumers (WidgetProfile,EnrollmentQuickActions,Stage,ProgramStageSelector,useFilteredWidgetData) read from the store.Key additions:
programOwners[program,orgUnit]is fetched with the TEI query →programOwnerIdreplaces URLorgUnitIdfor rule evaluation and profile saves (preventing accidental TEI relocation when saving Profile).WidgetProfilefiltersdisplayInListattributes againstrulesEffectsHiddenFields.WidgetProfile's public prop renamedorgUnitId→programOwnerId.