fix: [DHIS2-22007] comparison between the new and the cached rule messages - #4709
Open
superskip wants to merge 2 commits into
Open
fix: [DHIS2-22007] comparison between the new and the cached rule messages#4709superskip wants to merge 2 commits into
superskip wants to merge 2 commits into
Conversation
|
🚀 Deployed on https://deploy-preview-4709.capture.netlify.dhis2.org |
simonadomnisoru
approved these changes
Aug 24, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the implementation of a function called
getRuleMessages.The purpose of this function is to decide if two objects
ruleMessageandprevRuleMessageare identical.There was a case that was handled incorrectly by the previous implementation: the case where the keys of
ruleMessageis a subset of the keys ofprevRuleMessage.The new implementation is based on the assumption that the keys of the two objects must always be a subset of the values of the
messageStateKeys-object ('error','warning','errorOnComplete', and'warningOnComplete').