Conversation
In backendless mode all project reports are appended to a single "Digger run report" comment, but the "Plan output" and "Plan summary" section titles were hardcoded without the project name, unlike "Terraform plan validation check (<project>)". With multiple projects in one PR it was impossible to tell which plan output belonged to which project. Fixes diggerhq#2669
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2669.
In backendless mode, when multiple projects are impacted by a single PR, all reports are appended to one "Digger run report" comment (via
CommentPerRunStrategy). ThePlan outputandPlan summarysection titles were hardcoded without the project name, while theTerraform plan validation checksection already included it (Terraform plan validation check (<project>)). This made it impossible to tell whichPlan output/Plan summarysection belonged to which project when a PR touched more than one project.This PR makes
Plan outputandPlan summaryinclude the project name too, consistent with the validation check section:Changes
reportTerraformPlanOutputnow takes the project name and includes it in thePlan output (<project>)title.reportPlanSummarynow takes the project name and includes it in thePlan summary (<project>)title.job.ProjectName(previouslyreportTerraformPlanOutputreceivedprojectLock.LockId(), which was unused for the title).Test plan
go build ./...andgo vet ./pkg/digger/pass incli/go test ./pkg/digger/...passes incli/null_resourceprojects (env_dev,env_prd). Confirmed the posted comment showsPlan output (env_dev)/Plan output (env_prd)andPlan summary (env_dev)/Plan summary (env_prd)as expected.🧠 Ai UsageDetails (if applicable):
Used Claude Code to investigate the root cause, implement the fix, and verify it end-to-end against a live test repository. Diff reviewed and verified manually.