Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause: handleRequest in app/api.mjs called report.timezone.trim() unconditionally. The captured incident's "report-legacy" record has timezone: null, so .trim() threw TypeError: Cannot read properties of null (reading 'trim'), returning a 500 for GET /reports/report-legacy.
Fix: default to "UTC" when timezone is null/undefined before trimming:
(report.timezone ?? "UTC").trim(). Reports with a configured timezone (e.g. "Europe/London") are unaffected.Regression test added at app/test/api.regression.test.mjs, using synthetic state derived from the incident snapshot (report-legacy with timezone: null, report-current with timezone: "Europe/London"). It asserts the legacy report now returns 200 with timezone "UTC" and the correct generatedAt, and that the healthy report's response is unchanged. This test fails with the original TypeError before the fix and passes after.
Sentry incident: event. This is the deliberately faulty on-call example app.
Tested against commit
04b1e334a737824d719341f674d7048afa69401c. The same regression command failed before the fix and passed afterward: