Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause: handleRequest in app/api.mjs called report.timezone.trim() unconditionally. Legacy report records (created before timezone tracking existed) have timezone: null, so this threw "TypeError: Cannot read properties of null (reading 'trim')" and the request returned 500, matching the captured Sentry event for GET /reports/report-legacy.
Fix: default a missing/null timezone to "UTC" before trimming:
(report.timezone ?? "UTC").trim(). Reports with a valid timezone string are unaffected; reports with a null timezone now render using UTC instead of crashing.Regression test: app/test/api.regression.test.mjs exercises handleRequest with a synthetic report derived from the incident's captured state (id "report-legacy", timezone: null) and asserts a 200 response with a non-empty fallback timezone and generatedAt string, instead of the request throwing.
Sentry incident: event. This is the deliberately faulty on-call example app.
Tested against commit
b664e075ca7c0173b06f344d47a8cbcfa6e426fa. The same regression command failed before the fix and passed afterward: