Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Weibo. I do not have an account so it does not add all weibo (or if it does, it does it serendipitously). Mainly, search results and profile "timelines" are blocked when logged out so I've no idea if those will work (and no ability to test and make them work).
Also there is a https://weibo.com/tv page which I did not add. So far as I can tell, all those videos are available (weibo.com//) in the normal working format. But the data on that page is formatted completely differently. So we could support it, but we do not gain anything and we have to handle two different data formats (probably via
map_itemor reformat it pre storage which is anti ZS). Comments happen to be captured from that layout though.It would be really cool if we could get someone with an account to test this. Even better? If they can read Chinese. As I cannot and auditing the results is a bit of a matching game for me.
Lastly, I added a map_item that will be replaced once we have a 4CAT datasource. I found it useful to collect and then verify; though you can also use the browser debugger for that.