revert: pin node-red devDependency back to ^4.1.10 - #33
Merged
Merged
Conversation
node-red is a devDependency used only for compile-time TypeScript types and local manual testing; nothing in the codebase requires NR5's API surface, and the published package's actual compatibility floor is governed separately by the "node-red.version" field (unchanged, >=3.0.2). Not worth carrying the newer devDependency without a concrete reason to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import type NodeRed from 'node-red') and local manual testing — it's never shipped or executed at runtime for people using the published node."node-red": { "version": ">=3.0.2" }field, which is untouched.^4.1.10rather than carry the newer devDependency without a concrete reason.Test plan
npm run build && npm run lint && npm testall pass locally