Repository navigation
Upgrade to TypeScript 6 - #737
Merged
Merged
Conversation
… updates Bumps the build-tools group with 3 updates in the / directory: [@vitejs/plugin-react](https://github.com/vitejs/vite-plugin-react/tree/HEAD/packages/plugin-react), [typescript](https://github.com/microsoft/TypeScript) and [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite). Updates `@vitejs/plugin-react` from 6.1.1 to 6.1.2 - [Release notes](https://github.com/vitejs/vite-plugin-react/releases) - [Changelog](https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite-plugin-react/commits/plugin-react@6.1.2/packages/plugin-react) Updates `typescript` from 5.3.3 to 6.0.3 - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v5.3.3...v6.0.3) Updates `vite` from 8.3.4 to 8.3.5 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v8.3.5/packages/vite) --- updated-dependencies: - dependency-name: "@vitejs/plugin-react" dependency-version: 6.1.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: build-tools - dependency-name: typescript dependency-version: 6.0.3 dependency-type: direct:development update-type: version-update:semver-major dependency-group: build-tools - dependency-name: vite dependency-version: 8.3.5 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: build-tools ... Signed-off-by: dependabot[bot] <support@github.com>
TypeScript 6 rejects `target: es5` and `moduleResolution: node` (node10) with TS5107, which fails `tsc --noEmit` in node-lint. - `target` becomes es2022. With `noEmit` and an explicit `lib`, it only sets the language level tsc checks against; Vite does the transpiling. - `moduleResolution` becomes `bundler`, which matches how Vite resolves imports and reads `exports` maps. react-hook-form-mui's `date-pickers` subpath now resolves natively, so the `paths` override for it (in both tsconfig.json and tsconfig.paths.json) is removed, along with the now-empty tsconfig.paths.json and its Dockerfile COPY. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
barborico
marked this pull request as ready for review
November 5, 2026 01:09
Jeff-Rowell
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades TypeScript to 6.0 (with
vite8.3.5 and@vitejs/plugin-react6.1.2) and movestsconfig.jsonoff the options TypeScript 6 deprecates. This supersedes Dependabot's #734, whosenode-lintjob fails on those options.Urgency: LOW: patches no open security advisories.
Expected review effort: <5 min
Motivation
TypeScript 6 rejects
target: es5andmoduleResolution: node(node10) with TS5107, sotsc --noEmitfails. TypeScript 7 stays held back in.github/dependabot.ymlbecause the OpenAPI codegen depends on a compiler API it removes; 6.0 still ships that API.Detailed Description of Changes
targetbecomeses2022. WithnoEmitand an explicitlib, it only sets the language level tsc checks against; Vite does the transpiling.moduleResolutionbecomesbundler, which matches how Vite resolves imports and readsexportsmaps. react-hook-form-mui'sdate-pickerssubpath now resolves natively, so itspathsoverride goes away, along with the now-emptytsconfig.paths.jsonand itsCOPYin the Dockerfile.Validation
Confidence: high
tsc --noEmit,prettier --check ., andvitest run(205/205) pass locally on Node 22.23.vite buildpasses, both plain and withSENTRY_AUTH_TOKENset and an unreachableSENTRY_URL, so the Sentry plugin still loads and runs fromvite.config.ts, which tsc doesn't check.npm run codegenagainst an offline spec finishes on TypeScript 6 and produces no change tosrc/api/beyond the knownapiComponents.tsformatting churn.tsc --traceResolutionresolvesreact-hook-form-mui/date-pickersto itsdist/date-pickers.d.tswithout thepathsoverride.Guidance for Reviewers
Suggested approach: commit-by-commit. The first commit is Dependabot's version bump; the second is the tsconfig change.
The MUI 9 upgrade in #706 was type-checked on TypeScript 5.3, so whichever of the two lands second needs another
tscrun.🤖 Generated with Claude Code