Repository navigation
Bump env-cmd to 11 and @types/node to 26 - #739
Merged
Merged
Conversation
env-cmd 11 requires `--` between its own flags and the command it runs, so the `build` script now passes `-- vite build`; without it env-cmd 11 exits with an error and the production build fails. env-cmd 11 also treats an unquoted ` #` in `.env.production` as the start of an inline comment, which matches the dotenv parsing Vite's `loadEnv` already applies to the same file in vite.config.ts. @types/node 26 matches the Node 26 that CI and the Docker build stage run. This carries the env-cmd and @types/node bumps from Dependabot's npm-major group. Its react-hook-form-mui 9 bump needs MUI 9 and lands with the MUI upgrade instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
barborico
marked this pull request as ready for review
November 5, 2026 01:11
…_cmd_11 # Conflicts: # package-lock.json # package.json
Jeff-Rowell
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
env-cmdto 11 and@types/nodeto 26, and adds the--separator that env-cmd 11 requires to thebuildscript. This carries two of the three bumps from Dependabot's #730; its third, react-hook-form-mui 9, needs MUI 9 and lands with #706 instead.Urgency: LOW: patches no open security advisories.
Expected review effort: 1 min
Motivation
#730 fails every node job at
npm cibecause react-hook-form-mui 9 needs MUI 9. That failure also hid a second break: env-cmd 11 requires--between its own flags and the command it runs, soenv-cmd -f .env.production vite buildexits with an error and the production build fails.@types/node26 matches the Node 26 that CI and the Docker build stage run.Breaking Changes
env-cmd 11 treats an unquoted
#in.env.productionas the start of an inline comment. This only affects the frontend build, which is the one place env-cmd reads the file. It matches the dotenv parsing that Vite'sloadEnvalready applies to the same file invite.config.ts, so frontend build values shouldn't change. Operators who set a build-time value containing#should quote it.Validation
Confidence: high
npm run buildpasses with a.env.productionpresent. Without the--, env-cmd 11 fails.VITE_PROBE=a # breaches the command as"a".tsc --noEmitandvitest run(205/205) pass locally.🤖 Generated with Claude Code