Repository navigation
native implementation of ext4 directory hashing - #456
Merged
Merged
Conversation
Signed-off-by: Avi Deitcher <avi@deitcher.net>
deitch
force-pushed
the
rewrite-ext4-dirhashing
branch
from
November 4, 2026 09:33
a01705c to
f7df318
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #455
#455 found that the ext4 directory hashing code hewed a little too closely to the kernel original, which is open source but is licensed GPL-2. The boundary between "read the source and inspired to recreate" and "this might be a copy" was too close. At Ted T'so's suggestion, I took an AI agent, asked it to read the source and generate a spec describing the algorithm. This was placed in the markdown file included in this PR. I then removed the relevant files -
md4/md4.go,md4/md4_test.go,dirhash.go,dirhash_test.go- and asked a separate agent to implement the spec here without referencing any source code other than what is in this directory. The result is in this PR after my review.